Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http backend #596

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Fix http backend #596

merged 1 commit into from
Sep 29, 2024

Conversation

hatamiarash7
Copy link
Contributor

The http backend does not work because of the nil value of the HTTP header.

I think you intended to add the headers section to the config file in the future. Until then, we cannot use a nil value. Instead, we can put an empty http.Header{}.

jakthom
jakthom approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@jakthom jakthom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, :shipit: @hatamiarash7

@jakthom jakthom merged commit ccaf1ff into silverton-io:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakthom jakthom jakthom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatamiarash7 @jakthom